esm: restore next<HookName>'s context as optional arg
#43553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobJingleheimer
added
esm
|
Review requested:
|
GeoffreyBooth
approved these changes
Jun 23, 2022
aduh95
reviewed
Jun 23, 2022
aduh95
reviewed
Jun 24, 2022
aduh95
reviewed
Jun 24, 2022
| @@ -0,0 +1,3 @@ | |||
| export async function load(specifier, context, next) { | |||
There was a problem hiding this comment.
Can we also have a test for when the return value is null instead of Promise<null>?
Suggested change
| export async function load(specifier, context, next) { | |
| export function load(specifier, context, next) { |
There was a problem hiding this comment.
Yep! Will do tomorrow (alternatively in the tidy follow-up I'm about to do)
PS gaah, yah killin me with the drip-feeding 😜
JakobJingleheimer
force-pushed
the
esm/fix-optional-context-arg
branch
from
4227327
to
1f380d1
Compare
jasnell
approved these changes
Jun 27, 2022
JakobJingleheimer
force-pushed
the
esm/fix-optional-context-arg
branch
from
1f380d1
to
cb738d6
Compare
GeoffreyBooth
approved these changes
Jul 1, 2022
GeoffreyBooth
added
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1f6d005 |
This was referenced Jul 4, 2022
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43553 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43553 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43553 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43553 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports some internal code improvements otherwise lost when #43363 was reverted. It also contains a small bugfix wherein the
contextargument ofnext<HookName>()(ordefault<HookName>()prior to chaining) was actually optional.